navit-project.org

Looks like either 5884 or 5885 has broken the SDL graphics on Raspberry Pi (and possibly also other platforms). Now if I click on the map the menu does not appear, but the mouse seems to be "stuck" and moves the map. Clicking again doesn't change anything - the map follows the mouse, but there is no way to get into the menu or stop this map moving.

I can't see the problem right now as 5884 and 5885 are rather large changes... With 5883 it works fine.

Since it was me who made these changes, I feel a bit guilty .

The commits 5884 and 5885 were only intended to remove dead code. Mostly it was code which was permanently (I thought) disabled with #ifdefs. Typically something like "#undef BLA ... #ifdef BLA...#endif".

I'll try to reproduce the problem on Linux; if I can, it should not be hard to fix.

If not, I'll need your help. Could you check whether it's 5884 or 5885 which causes the problem? Also, could you somehow narrow down the problem? Are there any errror messages on the console? Does the build script for Raspberry Pi do anything funky?

I will check this as soon as I'm back home, probably on Sunday. The RPi build code does nothing unusual apart from enabling the SDL graphics module. I already had a brief look at the code changes, but did not see any obvious problem. I suspect it's somehow related to the mouse input.

Found it (I think). The problem is reproducible on Linux, too, when using SDL graphics.

Turns out it was a simple typo when fixing some warnings - I changed "0" to "1" in the mouse input handler :-/.
The bug was in r.5888 though, not in 5883/4.

Fixed in r.5902. Please test if this fixes the problem for you, too - just to be sure.

Great, looks like you found it! Now it works again without problems. Indeed, it was in 5888 - I did not see that that commit also concerned the mouse input, I had only seen the large changes in 5884 and 5885.