navit-project.org

forum for navit navigation tool
It is currently 24 Jun 2017, 19:07
View unanswered posts | View active topics


All times are UTC


Forum rules


Feel free to ask anything here related to the development process - coding, creating new features, fixing bugs and custom changes of Navit.

Note: For reporting bugs, use the bug tracker.



Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: SDL graphics broken on RPi after 5883
PostPosted: 28 Sep 2014, 08:50 
Online
User avatar

Joined: 07 Jun 2013, 17:13
Posts: 146
Location: Tartu, Estonia
Looks like either 5884 or 5885 has broken the SDL graphics on Raspberry Pi (and possibly also other platforms). Now if I click on the map the menu does not appear, but the mouse seems to be "stuck" and moves the map. Clicking again doesn't change anything - the map follows the mouse, but there is no way to get into the menu or stop this map moving.

I can't see the problem right now as 5884 and 5885 are rather large changes... With 5883 it works fine.


 Profile  
 
 Post subject: Re: SDL graphics broken on RPi after 5883
PostPosted: 02 Oct 2014, 12:22 
Offline

Joined: 23 Jun 2013, 20:15
Posts: 65
Location: Essen, Germany
xenos1984 wrote:
Looks like either 5884 or 5885 has broken the SDL graphics on Raspberry Pi (and possibly also other platforms).


Since it was me who made these changes, I feel a bit guilty :oops:.

The commits 5884 and 5885 were only intended to remove dead code. Mostly it was code which was permanently (I thought) disabled with #ifdefs. Typically something like "#undef BLA ... #ifdef BLA...#endif".

I'll try to reproduce the problem on Linux; if I can, it should not be hard to fix.

If not, I'll need your help. Could you check whether it's 5884 or 5885 which causes the problem? Also, could you somehow narrow down the problem? Are there any errror messages on the console? Does the build script for Raspberry Pi do anything funky?


 Profile  
 
 Post subject: Re: SDL graphics broken on RPi after 5883
PostPosted: 02 Oct 2014, 14:31 
Online
User avatar

Joined: 07 Jun 2013, 17:13
Posts: 146
Location: Tartu, Estonia
I will check this as soon as I'm back home, probably on Sunday. The RPi build code does nothing unusual apart from enabling the SDL graphics module. I already had a brief look at the code changes, but did not see any obvious problem. I suspect it's somehow related to the mouse input.


 Profile  
 
 Post subject: Re: SDL graphics broken on RPi after 5883
PostPosted: 03 Oct 2014, 12:24 
Offline

Joined: 23 Jun 2013, 20:15
Posts: 65
Location: Essen, Germany
Found it (I think). The problem is reproducible on Linux, too, when using SDL graphics.

Turns out it was a simple typo when fixing some warnings - I changed "0" to "1" in the mouse input handler :-/.
The bug was in r.5888 though, not in 5883/4.

Fixed in r.5902. Please test if this fixes the problem for you, too - just to be sure.


 Profile  
 
 Post subject: Re: SDL graphics broken on RPi after 5883
PostPosted: 05 Oct 2014, 13:26 
Online
User avatar

Joined: 07 Jun 2013, 17:13
Posts: 146
Location: Tartu, Estonia
Great, looks like you found it! Now it works again without problems. Indeed, it was in 5888 - I did not see that that commit also concerned the mouse input, I had only seen the large changes in 5884 and 5885.


 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Silver Orange 2.0.6 for IPB Designed by Skins and Hosting
Converted for phpBB3, based on Royal Blue template by BigB © 2007 2008 AEON KINGS